search

phptek / silverstripe-sentry

Flexible Sentry compatible bug aggregation client for Silverstripe applications.
BSD 3-Clause "New" or "Revised" License
11 stars 22 forks source link

SS3.7.x + PHP7 #47

Closed Firesphere closed 3 years ago

Firesphere commented 4 years ago

PHP7 is not supported for SilverStripe 3.7.x versions, despite the framework supporting php7.

This causes installation issues with composer, that should not be necessary

phptek commented 4 years ago

If by "SilverStripe" you don't mean "framework", what do you mean?

Firesphere commented 4 years ago

The SS3 version has a limit to PHP < 7. Despite SS3.7.x supporting PHP7

shanholmes commented 3 years ago

+1. I've just come across this issue. SS3.7.x supports PHP7.3 but the version of this module limits the PHP <7.

phptek commented 3 years ago

If someone chucks me a PR I'll merge it

Firesphere commented 3 years ago

https://twitter.com/Firesphere/status/1288310045625577475?s=20

shanholmes commented 3 years ago

I've created a PR @ https://github.com/phptek/silverstripe-sentry/pull/52 There doesn't seem to be a branch for the 1.X version for me to merge into, so I have put it as master (sorry if thats wrong). Maybe we could add a persistent 1.X branch rather than a tag? Thanks!

phptek commented 3 years ago

Released 2.2.0 and 3.0.5 with relevant patches. Thanks folks.