phptek / silverstripe-sentry

Flexible Sentry compatible bug aggregation client for Silverstripe applications.
BSD 3-Clause "New" or "Revised" License
11 stars 22 forks source link

Version 3.0.5 PHP7.4+ install issue #60

Closed cameronbourgeois closed 3 years ago

cameronbourgeois commented 3 years ago

The Requirements section of the README gives us:

SilverStripe 4 PHP >=7.0 SilverStripe ^4.0

SilverStripe 3 PHP 5.4+, <=7.4 SilverStripe v3.1.0+, < 4.0

However, version 3.0.5 of this module seems to have implemented a blanket requirement for PHP 5.4+, <=7.4, thereby making the module uninstallable on PHP 7.4+.

I need to downgrade back to 3.0.4 to get this module installed for my PHP7.4 / SS4 project.

arthur-apanovics commented 3 years ago

Having the same problem. Seems that SS3 requirement was accidentally used in composer.json for 3.0.5.

Could you please create a new tag so that we can lock our composer.json to a specific verion? Thanks!

phptek commented 3 years ago

Hi folks, so sorry about delays. I've had a few hours to dedicate to this. Can you try 3.0.10 which stipulates:

    "require": {
        "php": "^5.4|<7.5",
        "sentry/sdk": "^2",
        "silverstripe/framework": "^4"
    },

Perhaps it should just be:

    "require": {
        "php": ">=5.4",
        "sentry/sdk": "^2",
        "silverstripe/framework": "^4"
    },

@arthur-apanovics, @cameronbourgeois

phptek commented 3 years ago

Closing in light of the production of 3.0.10 and the imminent 4.0.0