phpv8 / php-v8

PHP extension for V8 JavaScript engine
https://php-v8.readthedocs.io
MIT License
217 stars 14 forks source link

Upgrade libv8 dependency to 6.3 branch #45

Closed pinepain closed 7 years ago

pinepain commented 7 years ago

v8 6.3 is out and as we stick to the latest v8 version, it's time.

There is also change in late 6.2 (Pass Isolate pointer to String::Utf8Value/Value constructors https://github.com/v8/v8/commit/fe598532ec1317e8b85343133be9fb708e07bd2e in 6.2.396) we might benefit from and as 6.3 is out there is no major reason against upgrading libv8 dependency.

pinepain commented 7 years ago

After updating some tests become red and reports leaks - https://travis-ci.org/pinepain/php-v8/jobs/271257124. I'm not sure was there any changes in v8 internals that affects userland code and thus need some adjustmets or it's a v8 internals issue or it just false-positive. Filled a report to v8-users mail lists - https://groups.google.com/forum/#!topic/v8-users/qu1HrjbgRsg.

Moving this into separate issue #47.