search

phpv8 / php-v8

PHP extension for V8 JavaScript engine
https://php-v8.readthedocs.io
MIT License
217 stars 14 forks source link

Script cache creating is broken after bumping v8 version to 6.6.313 #99

Closed pinepain closed 6 years ago

pinepain commented 6 years ago

It was known to be working in 6.6.275, however in 6.6.313 we have caching broken (https://travis-ci.org/pinepain/php-v8/jobs/345791065#L3109) - all tests return NULL for generated cache. I guess we need to make minimal example to reproduce and validate whether it's not a some obvious integration issue and then ask v8-users for help.

pinepain commented 6 years ago

Here's a deal breaker - https://github.com/v8/v8/commit/5a68df2ab528ae8248806ae4fe7f8b52a14f731c