Closed avltree closed 7 years ago
Just curious ... which part of the existing API are you hooking into the V8Object? This shouldn't be possible from PHPland which is why it's currently not documented.
A V8Object
doesn't help much, yet it would allow to "type hint" arguments and in @var
docblocks (when you keep a V8Object
instance in a PHP variable. So it doesn't help much, just autocompletion of the class name itself + IDE doesn't highlight a non-existing class.
Likewise for V8Function
and V8Generator
Yeah up to you @stesie if you want to add these. If so, we can continue to update Readme over in V8JS and then copy changes over here in php7
branch. Probably no need to update legacy master branch. Otherwise, if there's no rational to include these, then we can close.
@virgofx I've added V8Object
et al now. I also noticed that V8JsException
was missing also (and the other exception classes were telling to just extend from Exception
).
What now? I haven't published anything on packagist so far TBH :) Could you please add me to the package or phpv8
org or whatever there. My nick is now also "stesie" there. Thanks.
Don't bother updating the package if its beyond trivial. I'm considering publishing 1.3.2 (with recent bug fixes) and 1.4.0 with require improvements within shortly anyways
@stesie Packagist updates automatically. Also added you as maintainer (Although everything is setup automatic so shouldn't need to do anything).
All that is needed is just adding a tagged release. Just copy previous ones. I was doing them to conincide with V8JS. I'm 2 versions behind (Currently @ 1.3.1). So we just need to tag 1.3.2. and 1.3.3 (Any 1.4 if released next). You should be able to go ahead and do those now. If you do these two releases now, you'll be able to help when you release future versions (as I forget to update sometimes).
Since lots of times no API changes every time I bumped the revision portion (1.3.X) in the README.md
as just a noop commit before tagging the next revision (that way tagged releases show up properly in order with different commit hashes).
The packagist badge should update in about 5-10 minutes after creating a release.
So in short ... 1) Noop commit Readme to 1.3.2 2) Create release 1.3.2 (Similar format as 1.3.1). 3) Noop commit Readme to 1.3.3 4) Create release 1.3.3 (Similar format as previous). 5) Packagist will update immediately. The badge takes about 5-10 minutes to update cache.minutes).
Well, the title says it all ;)