search

phpv8 / v8js

V8 Javascript Engine for PHP — This PHP extension embeds the Google V8 Javascript Engine
http://pecl.php.net/package/v8js
MIT License
1.84k stars 200 forks source link

Unstable/unusable builds since 3.29.36 #103

Closed stesie closed 10 years ago

stesie commented 10 years ago

We need to call v8::V8::InitializePlatform on startup now and v8::V8::ShutdownPlatform on shutdown.

See http://comments.gmane.org/gmane.comp.lang.javascript.v8.general/8029

stesie commented 10 years ago

I've prepared a fix at https://github.com/stesie/v8js/tree/fix-init-platform Maybe someone is willing to give it a try with a recent v8 version.

V8 now ships with a small library named libplatform, which we can use to provide a platform implementation to V8 (instead of providing our own)

rosmo commented 10 years ago

Could you build that branch on Jenkins? It would probably provide the best feedback if this still work.

stesie commented 10 years ago

Sure I can, and I'm actually on it. However I first have to rebuild the latest v8 library versions and keep the libplatform stuff as well.

Apart from that, I actually wanted to signalize that I'm working on the topic and wanted to collect some feedback whether using libplatform is the way to go for us. It's complicating the build process a little bit, but should still be ok ...

stesie commented 10 years ago

Ok, Jenkins finished his work ... everything's building fine, hence I'll go and merge ...