search

phpv8 / v8js

V8 Javascript Engine for PHP — This PHP extension embeds the Google V8 Javascript Engine
http://pecl.php.net/package/v8js
MIT License
1.84k stars 200 forks source link

Tests "V8Js::setModule" is failing with V8 >= 5.2.51 #230

Closed AlexMasterov closed 8 years ago

AlexMasterov commented 8 years ago 
PHP_VERSION : 7.0.5
ZEND_VERSION: 3.0.0
PHP_OS      : Linux - Linux 04b81f41609e 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt25-1 (2016-03-06) x86_64
PHP Api Version:       20151012
Zend Module Api No:    20151012
Zend Extension Api No: 320151012
FAILED TEST SUMMARY
---------------------------------------------------------------------
Test V8Js::setModuleLoader : Returned modules are cached [tests/commonjs_caching_001.phpt]
Test V8Js::setModuleLoader : module cache seperated per isolate [tests/commonjs_caching_002.phpt]
Test V8Js::setModuleNormaliser : Custom normalisation #001 [tests/commonjs_cust_normalise_001.phpt]
Test V8Js::setModuleNormaliser : Custom normalisation #002 [tests/commonjs_cust_normalise_002.phpt]
Test V8Js::setModuleNormaliser : Custom normalisation #003 [tests/commonjs_cust_normalise_003.phpt]
Test V8Js::setModuleNormaliser : Custom normalisation #004 [tests/commonjs_cust_normalise_004.phpt]
Test V8Js::setModuleLoader : CommonJS modules [tests/commonjs_modules.phpt]
Test V8Js::setModuleLoader : Assign result multiple times [tests/commonjs_multiassign.phpt]
Test V8Js::setModuleLoader : Path normalisation #001 [tests/commonjs_normalise_001.phpt]
Test V8Js::setModuleLoader : Path normalisation #002 [tests/commonjs_normalise_002.phpt]
Test V8Js::setModuleLoader : Path normalisation #003 [tests/commonjs_normalise_003.phpt]
Test V8Js::setModuleLoader : Path normalisation #004 [tests/commonjs_normalise_004.phpt]
Test V8Js::setModuleLoader : Path normalisation #005 [tests/commonjs_normalise_005.phpt]
Test V8Js::setModuleLoader : Module source naming [tests/commonjs_source_naming.phpt]

Also, I've noticed that they changed the location libv8_libplatform.a (V8 >= 5.2.125): out/native/obj.target/tools/gyp/libv8_libplatform.a changed to out/native/obj.target/src/libv8_libplatform.a

stesie commented 8 years ago

Thanks for the report and sorry for not answering earlier.

I've fixed that for the PHP5 version today and will follow up with a bugfix release for PHP5, then merge to the PHP7 branch and release that.