V8 crashing on toLocaleString()

temuri416 commented 7 years ago

The following expression crashes V8JS:

var date = new Date("10/11/2009"),
    locale = "en-us",
    month = date.toLocaleString(locale, { month: "long" });

Results in:

 kernel: [10936.602251] traps: php-fpm[8516] trap invalid opcode ip:7f9239f2526f sp:7ffff8f825f8 error:0 in libv8_libbase.so[7f9239f16000+14000]

The problem is toLocaleString() call.

I realize it's not the fault of V8JS... But maybe @stesie has an idea of what's happening? It was fine with 5.5.x versions of V8.

Thanks!

temuri416 commented 7 years ago

just as I suspected - v8_enable_i18n_support = false should also be supplied during configuration...

~~now everything works fine.~~

EDIT. Nope, .toLocaleString() no longer crashes V8, but does not return month name :(

temuri416 commented 7 years ago

Decided to reopen... V8 itself handles toLocaleString() correctly:

Running:

/tmp/v8/out.gn/x64.release/d8

After compiling V8JS running the following:

$v8 = new V8Js;
$expr = 'new Date("10/11/2009").toLocaleString("en-us", { month: "long" });';
echo $v8->executeString($expr, null, V8Js::FLAG_FORCE_ARRAY);

results in:

#
# Fatal error in , line 0
# Failed to create ICU date format, are ICU data files missing?
#

==== C stack trace ===============================

    /opt/v8/lib/libv8_libbase.so(v8::base::debug::StackTrace::StackTrace()+0xe) [0x7f7874e1b32e]
    /opt/v8/lib/libv8_libplatform.so(+0x61b5) [0x7f7874e281b5]
    /opt/v8/lib/libv8_libbase.so(V8_Fatal+0xdd) [0x7f7874e191ed]
    /opt/v8/lib/libv8.so(+0x5a3ed0) [0x7f786fac4ed0]
    /opt/v8/lib/libv8.so(+0x7537bd) [0x7f786fc747bd]
    [0x39243ffbda18]
Received signal 4 ILL_ILLOPN 7f7874e1a26f
Illegal instruction (core dumped)

V8 compiles icudtl.dat and places it alongside libv8.so. Before compiling V8JS I copied icudtl.dat to /opt/v8/lib.

Could this be helpful?

https://groups.google.com/forum/embed/#!topic/v8-users/4DOD6z57xfU

Do you call V8::InitializeICU() or V8::InitializeICUDefaultLocation() before V8::Initialize()?

https://github.com/phpv8/v8js/blob/php7/v8js_v8.cc#L80

Any idea?

Thanks!

duxet commented 7 years ago

@temuri416 Same issue with the newest build of my Docker image:

#
# Fatal error in , line 0
# Failed to create ICU date format, are ICU data files missing?
#

==== C stack trace ===============================

    /usr/v8/lib/libv8_libbase.so(+0x1044e) [0x7f32fc53844e]
    /usr/v8/lib/libv8_libbase.so(V8_Fatal+0xdf) [0x7f32fc5363af]
    /usr/v8/lib/libv8.so(+0x5903b0) [0x7f32ef89c3b0]
    /usr/v8/lib/libv8.so(+0x75310d) [0x7f32efa5f10d]
    [0x1f5b578b5fc2]
Illegal instruction

stesie commented 7 years ago

I've got this to work on MacOS and Linux so far, see #307.

Yet I wonder how to fix it on Windows. @Jan-E could you please check whether the build of V8 on Windows also yields a icudtl.dat file? Your ZIP archives seem to not ship it, but I'd suppose it to be there