search

phpv8 / v8js

V8 Javascript Engine for PHP — This PHP extension embeds the Google V8 Javascript Engine
http://pecl.php.net/package/v8js
MIT License
1.84k stars 200 forks source link

Call v8::RegisterExtension using unique_ptr #405

Closed jalr closed 5 years ago

jalr commented 5 years ago

Using this fix, I was able to build v8js with v8 version 7.6.57

stesie commented 5 years ago

Hej jalr, thanks for your contribution. There was one issue left regarding a double-free segfault with the extension related tests. Since php-v8js still was managing the v8::Extension * instance ... however v8 was now expecting to do that on it's own (hence the unique_ptr)

I tried to address that with #415 and will merge once tests are green