Broken build on PHP 8.0.x

phpv8 / v8js

V8 Javascript Engine for PHP — This PHP extension embeds the Google V8 Javascript Engine

http://pecl.php.net/package/v8js

MIT License

1.84k stars 200 forks source link

Closed marekskopal closed 1 year ago

marekskopal commented 1 year ago

Hi,

After changes from this pull request https://github.com/phpv8/v8js/pull/498 build on PHP 8.0.x is broken.

If I revert those changes, build works fine.

On 8.1.x its fine too.

I suppose that zend_is_graceful_exit is not present in 8.0

marekskopal commented 1 year ago

I created a pull request that should fix it https://github.com/phpv8/v8js/pull/503

stesie commented 1 year ago

PR's merged. Thanks for pointing this out 👍