phpv8 / v8js

V8 Javascript Engine for PHP — This PHP extension embeds the Google V8 Javascript Engine
http://pecl.php.net/package/v8js
MIT License
1.84k stars 200 forks source link

* tests/timezones.phpt - added LC_ALL=C to prevent test failing when … #507

Closed chrisbckr closed 1 year ago

chrisbckr commented 1 year ago

…another locale is set as default

My LC is set to pt_BR.utf8/pt_BR, so the test always will fail without setting LC_ALL=C.

---- EXPECTED OUTPUT
Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
Thu Mar 20 2014 05:03:24 GMT-0400 (Eastern Daylight Time)
Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
===EOF===
---- ACTUAL OUTPUT
Thu Mar 20 2014 11:03:24 GMT+0200 (Horário Padrão da Europa Oriental)
Thu Mar 20 2014 05:03:24 GMT-0400 (Horário de Verão do Leste)
Thu Mar 20 2014 11:03:24 GMT+0200 (Horário Padrão da Europa Oriental)
===EOF===
---- FAILED

But in fact the test was a success. Setting LC_ALL=C will prevent this.

stesie commented 1 year ago

hmm, I wonder whether we should set this to C.UTF-8 like we already do in the Dockerfiles that run the tests automatically. Or at least used to do 🙈

But C should suffice so I don't mind.

Thanks for your contribution!