phpv8 / v8js

V8 Javascript Engine for PHP — This PHP extension embeds the Google V8 Javascript Engine
http://pecl.php.net/package/v8js
MIT License
1.84k stars 200 forks source link

add ci test on alpine #538

Closed stesie closed 1 month ago

JoshuaBehrens commented 1 month ago

Feels like we want to have the phpt test results as artifact on the run so one can view them? One should be able to get into this without having to run it locally again.

Do you want to save this report in a file? [Yn]: Report saved to: /home/runner/work/v8js/v8js/php_test_results_20240929_1624.txt

I assume something like this would be beneficial to better understand issues reported online

      - name: Archive test results
        if: always()
        uses: actions/upload-artifact@v4
        with:
          name: phpt-test-results
          path: php_test_results*.txt
stesie commented 1 month ago

d'accord, collection makes sense. I've added it in failure case only though. Seems to work fine -> https://github.com/phpv8/v8js/actions/runs/11094647649/job/30822343118

And I've compiled 11.3.244.8 on my Ubuntu machine "quickly", and there the test fails as well. Seems like an issue with V8 itself, that the setter is invoked twice there. Unfortunate that it ocurs on exactly the version that's shipped with alpine, but I would just ignore it for the moment (i.e. skip this particular test for that V8 version)