search

phpv8 / v8js

V8 Javascript Engine for PHP — This PHP extension embeds the Google V8 Javascript Engine
http://pecl.php.net/package/v8js
MIT License
1.84k stars 200 forks source link

php 8.4 compile error - php_strtolower not declared #540

Open rbro opened 3 weeks ago

rbro commented 3 weeks ago

When compiling v8js against PHP 8.4.0RC3, I got the below error:

/tmp/v8js/v8js_object_export.cc:678:9: error: ‘php_strtolower’ was not declared in this scope; did you mean ‘php_strtok_r’?

I found the below change in PHP:

https://github.com/php/php-src/commit/85e6688791771f4af575de2421e4f9c1638805a5

Also, I found this reference:

https://github.com/Imagick/imagick/pull/690

I tried a quick test and changing v8js_object_export.cc to call zend_str_tolower instead of php_strtolower seems to work.

Thanks for your help.