search

phpvms / phpvms_v2

Virtual Airline Management (not maintained)
http://www.phpvms.net
BSD 3-Clause "New" or "Revised" License
41 stars 46 forks source link

Strtic Standards: PHP Version 5.4.7 #102

Open Vansers opened 11 years ago

Vansers commented 11 years ago

So far, I have seen too much Strict Standards errors on phpVMS while using PHP Version 5.4.7. I'm thinking we should tackle this because what if the hosting upgrades their PHP Version. What you think?


Strict Standards: Accessing static property Operations::$get as non static in \phpvms\admin\modules\Operations\Operations.php on line 167

Strict Standards: Accessing static property Operations::$get as non static in \phpvms\admin\modules\Operations\Operations.php on line 168

Oxymoron290 commented 11 years ago

I develop in a php5.4 environment also, and normally before submitting pull requests ill undo this fix to keep it uniform with the current installation. Check out commit a18d2d828fc29b9280eb03726447310c559d6e51 this is normally how I suppress the 5.4 strict standards, but I'm not sure if it's desirable.

Note: This commit undoes the suppression, which I accidentally added in commit b8f8681512fec3e2ccbcc6501046ee9688238c2a

Vansers commented 11 years ago

No worries, I do as well develop on 5.4 as well. Just the feeling to be kept updated with PHP. ;)

We might should take a look this, keep the suppress in with the older build, but not sure if it will affect the other versions of PHP.

nabeelio commented 11 years ago

Is there an update for that charts library?

Oxymoron290 commented 11 years ago

I'm not sure, I haven't looked into it.