search

phpvms / phpvms_v2

Virtual Airline Management (not maintained)
http://www.phpvms.net
BSD 3-Clause "New" or "Revised" License
41 stars 46 forks source link

Repair dropdown selection & FSFK Map Additions #115

Closed DavidJClark closed 10 years ago

DavidJClark commented 10 years ago

Repair dropdown selection in admin settings template for default user field.

FSFK map additions.

Signed-off-by: DavidJClark david@noticeabledesigns.com

Oxymoron290 commented 10 years ago

change $sel = ($current->value == $group->groupid ? 'selected="selected"' : ''); to $sel = ($current->value == $group->groupid ? 'selected' : ''); as this attribute doesn't hold a value, it's simply set when the attribute key exists. However most browsers do allow for a value to this attribute and in that case the value would be boolean, either true or false. In no case is the value "selected" valid for the selected attribute.

sauce: http://stackoverflow.com/questions/1033944/what-values-can-appear-in-the-selected-attribute-of-the-option-tag

also, good catch.

DavidJClark commented 10 years ago

@Oxymoron290 - That part does not matter to me, I wrote it out of habit. The change that was made to make the drop down function correctly is:

$current to $current->value