phpvms / phpvms_v2

Virtual Airline Management (not maintained)
http://www.phpvms.net
BSD 3-Clause "New" or "Revised" License
41 stars 46 forks source link

Code Review #118

Open Oxymoron290 opened 11 years ago

Oxymoron290 commented 11 years ago

on app.config.php

There is not setting for CURRENT_SKIN - why? Possibility for conflicting values between lines 163-171 and lines 57-59 - why? Line 187, 192, 319, 325, 327, 330, 332, 337, 536 and 537 is using a string literal directory separator instead of the defined DS global - why? line 187 is using a string literal directory separator instead of the defined DS global - why? line 319 is using a string literal directory separator instead of the defined DS global - why?

There is a configuration setting for BASE_TEMPLATE_PATH, but not one for admin - WHY?

Lines 327, and 337 use the same value, Why not copy the code from the condition above on line 335? Config::Get('BASE_TEMPLATE_PATH');

permission description array is missing MAINTENANCE Description (i know, that's partially my fault.

bootstrap.inc.php

lines 22, 27, is using a string literal directory separator instead of the defined DS global - why?