search

phrase / ios-sdk

Phrase Over the Air iOS SDK
https://phrase.com
Other
14 stars 3 forks source link

Better support for using PhraseSDK in extension (remove warning) #22

Closed cheif closed 3 years ago

cheif commented 3 years ago

Hi!

Right now it's possible to link against PhraseSDK from an extension, but you'll get the warning: ld: warning: linking against a dylib which is not safe for use in application extensions: .../PhraseSDK.framework/PhraseSDK

I guess we're not unique in our desire for using OTA updates in extensions, and I hope that there's something you can do about it. In the best case it should just be to flick on APPLICATION_EXTENSION_API_ONLY = YES; in your build settings, but I realise that you might actually be using API:s that's not available in extensions.

winkelsdorf commented 3 years ago

Hi @cheif,

that's an excellent suggestion, thanks for bringing it to our attention!

You are right, we need to check API usage and for correct handling of Bundles and Network Sessions. I'll discuss this with the team and will keep you updated on this.

winkelsdorf commented 3 years ago

@cheif Just wanted to let you know, that the upcoming release will close this issue in a few days.

cheif commented 3 years ago

@winkelsdorf Looking forward to it! :)

winkelsdorf commented 3 years ago

@cheif New version is live. Looking forward to your feedback.

cheif commented 3 years ago

Now I've verified that we don't get the warning any more, great work @winkelsdorf !

winkelsdorf commented 3 years ago

@cheif Thank you very much for your kind words and the feedback, really appreciate that!

Just a note, currently the dSYMs shipped with the (xc)framework break the lldb debugger. See #30. We'll release a hotfix shorty, in the meantime you could simply delete the shipped dSYMs coming with the SDK.

cheif commented 3 years ago

Thank for the heads-up, I'll just hold of merging until 3.0.1 is out.

winkelsdorf commented 3 years ago

You're welcome! Yes, that's probably the best. Keeping you updated :)

winkelsdorf commented 3 years ago

@cheif v3.0.1 is out now. May take some time for CocoaPods to distribute the new Podspec (they have some issues the past 24 hrs).