phrase / phrase-cli

CLI for the Phrase API
https://developers.phrase.com
MIT License
42 stars 6 forks source link

Fetch proper fallback locale from the language configuration during phrase pull #113

Open alexsergivan opened 2 years ago

alexsergivan commented 2 years ago

Hi! When I execute phrase pull, I expect that it automatically recognizes the fallback locales if some translation is empty and put translation from the fallback, that I specified for every language in the Phrase admin panel. Unfortunately, it does not work in that way. I know that I can specify fallback_locale_id for every target in .phrase.yml, but it's not scalable. We have many projects with > 40 languages each, and if we would do so, we would have many enormously complicated .phrase.yml files. And for me it does not make sense, because the fallbacks configuration is already done here:

Screen Shot 2022-09-13 at 19 16 46

Currently, we configured targets in this way: - file: ./translations/translation.<locale_name>.yml

Thank you!

github-actions[bot] commented 2 years ago

Hello,

Thanks for reaching out to us.

I will start looking into your issue and get back to you as soon as I know more.

Please make sure you provided all the information that could be helpful with the investigation (see the automated response you received when creating this ticket). I might have to prioritize your request against other support tickets, so please indicate if there is a particular urgency to your request and whether you are blocked by the issue you reported.

Thank you for your understanding, and I'll get back to you shortly.

Best, Ryan from the Phrase Technical Support Team

Comment by Ryan

github-actions[bot] commented 2 years ago

Hello,

You can do it with the param, there is no alternative. If it is the same fallback locale for all languages, you can combine it with the placeholder, but otherwise you will need a separate target for every language.

I can submit a feature request to see about adding this, but cannot guarantee if or when it would be added.

Best, Ryan

Comment by Ryan

alexsergivan commented 2 years ago

Hi Ryan, thank you for your answer! Would be really nice to have this implemented in the future. It will simplify our phrase.yml files a lot. Because we have variety of fallback languages.

github-actions[bot] commented 2 years ago

Hello,

Thank you for your feedback. This email confirms that we have forwarded your idea to our Product team.

Idea: Fetch proper fallback locale from the language configuration during phrase pull (Github)

Please note that I cannot make any promises on whether and if so when this request will be implemented. We will do our best to keep you updated!

Have a good day,

Ryan from the Phrase Technical Support Team

Comment by Ryan

alexsergivan commented 2 years ago

Thanks a lot!

alexsergivan commented 1 year ago

Hi again! Just wondering, if maybe you have some updates related to this issue. It's not easy to manage a .phrase.yml file with thousands of lines inside, especially if we need to launch a new market and introduce a new locale...

jablan commented 1 year ago

hey @alexsergivan thanks for (re)raising the issue and sorry that this hasn't been addressed yet. We opened an internal issue now, however we can't say when we'll get to implement it.