egze
commented
2 years ago We have decided to close all GitHub issues and, instead, handle them through our Customer Support. We think this shift will allow us to offer proper prioritization of issues as well as a more appropriate response time that would be expected from Phrase products.
We apologize for any inconveniences this may cause. If you believe your issue is still relevant or has a high priority, please contact support@phrase.com, and we can take more direct action toward finding a solution.
First of all, thank you guys for a great job!
Here's the issue we found out when trying to update our client from 1.16 up.
Problem description
We use phrase cli and additional tooling in several of our repos. Each uses similar set of tools and, as an example one of in-house operations connects directly to phrase for storing the data, the other uses cli to pull data from phrase.
In order to make it simple we have put the configuration for all tools into one yaml file, that is read by both phraseapp and our own tool.
Using CLI 1.16 there's no issue and all works fine, but witching to newer client results with an error.
I've managed to pinpoint it to this part of code: https://t.sidekickopen78.com/s1t/c/5/f18dQhb0S7lM8fTm3rW3hl9J-2B9nMJN7t5XWPfhMynW2zWYS07fRFQ-W56dvFV1ByRZ6102?te=W3R5hFj4cm2zwW3P28X24hCPvhW43T4P43R4r11W3JFY1b49HSzfW1GBFjh3CbHnbW1LwVdN1_kF32W1_khrY1N4h9KW1N5Zfz3z9CVBW1-YW5r1SqD57W1XnxCX1W_Q9LW3yMKTZ41RL2hW1Jz9Qf2PlqpGf1Gnj79X3&si=8000000002694398&pi=fc8a4ed2-3a3b-4373-9c5b-ba57a8cd74f1
Suggested change
The code for reading config should not be this strict. I understand the need of verifying the config for phrase, but it could be done based on the main key
phraseandphraseapp. This way there can be multiple config for different apps.