Make Iron Curtain work - Githubissues

phrohdoh / OpenRA

GNU General Public License v3.0

23 stars 3 forks source link

Make Iron Curtain work #48

Closed MustaphaTR closed 9 years ago

MustaphaTR commented 9 years ago

Fixes a part of #26.

I tried changing Cursor but didn't work not sure why. When activated first time last frame of active anim stops there and doesn't get removed.

Do we have charged anims in OpenRA. In RA2 SWs goes to their charged anim when 1 minute left.

phrohdoh commented 9 years ago

I remember Iron Curtain being commented-out for some actor definitions in the past. Please find out why and be sure we aren't introducing duplicate definitions.

MustaphaTR commented 9 years ago

I took a look to code now but couldn't see anything commented out about IC.

phrohdoh commented 9 years ago

@abcdefg30: Could you test this ingame if you have time to verify valid sequences?

abcdefg30 commented 9 years ago

Looks good to me. :+1: / :white_check_mark:

A few sidenotes though:

The idle animation stops after using the curtain once
What does ngiron_f do? (I suspect that could be the active animation)

GraionDilach commented 9 years ago

ngiron_f is the charged sequence. https://github.com/Phrohdoh/oramod-ra2/blob/master/extra-files/art.ini#L1369

In RA2, when the SW reaches 1 minute cooldown, the building plays SuperAnimTwo once, then use SuperAnimThree as idle overlay until the SW gets fired when SuperAnimFour is played to go back into SuperAnim.

phrohdoh commented 9 years ago

Is that setup currently possible? If not the idle anim should at least be fixed then this can be taken.

GraionDilach commented 9 years ago

Best we can do atm is to make a GrantUpgradeSequence from SuperAnimTwo and SuperAnimFour using combined sequences.

phrohdoh commented 9 years ago

@GraionDilach I'm pretty busy currently, would you mind opening a follow-up PR if I merge this as-is?