Closed Shrugsy closed 3 years ago
Looks good, but could you make the return
an await
and the test functions async
please?
Gonna be super awkward otherwise if at some point we forget about this and want multiple expect
calls in one test.
Looks good, but could you make the return an await and the test functions async please? Gonna be super awkward otherwise if at some point we forget about this and want multiple expect calls in one test.
Yup, all done. I hadn't actually realised awaiting the expect().rejects
was possible at the time or I would have done that in the first place
As per title: adds support for hyphens in virtual filenames
e.g.
Also adds
return
s to the relevantexpect
statements in tests that expected a promise to eventually resolve/throw (otherwise they resolve/throw outside of the tests, and the tests can report false positives)