Closed VIDGuide closed 2 years ago
The PR description does not quite line up with the content. This appears to add cards for:
Can you demonstrate that all of these function as intended, and provide screenshot or screencast evidence of this? I do not own these devices and cannot simulate these cards to test them.
Before I ultimately accept this, I would need you to fix the masking on the miniwasher card, and modify the README (with its own section) to show examples of these cards in use, much like how the existing README shows the washer and dryer cards.
Ah yes, sorry, I kept working on this a bit further after the PR went up. Yes, this adds 3 types, all of which I have, and have it working with.
If there is any todo on this one yet to come, it's that the icons aren't 100% correct (I've used the washing machine icons for the dish washer, but have read your tip in the Issues, and will update this soon)
I will also update the read-me for the other devices.
As it stands right now:
Only the combo-washer/drier is running right now, but I'll try to get some snaps as the others go into use and compile into a readme.
The mini-washer is basically 100% the same as the regular washer, just a different name/ID. The combo is effectively combining a few elements from the individual washer/drier elements into one.
The dish-washer is surprisingly similar, just again, some different naming.
So leave this open (or reject, up to you) for the minute, and I'll push another update soon with new icons for the dish washer, and an updated read-me with examples on each.
I definitely won't reject this, it looks great! I look forward to updates as they come, and if you need me to tweak the backgrounds for you, just give me assets/model info. Similarly, if I have free time, I can pull down state icons for you if you give me the official manual.
I will update the PR/Readme with these picture as well, but putting here for reference.
Mini Washer in operation
Dishwasher in operation:
The dishwasher is model XD3A25BS, but I'd imagine the values used here would apply to any/all ThinQ enabled dishwashers.
The mini-washer is WTP20WY, and it works just like a regular washing machine, albeit limited features. The icons are perfectly applicable for this one, it uses identical icons as the other washer & dryer machines, so they suit just fine.
Updated readme and the configuration.yaml
Manual for the dishwasher is https://gscs-b2c.lge.com/downloadFile?fileId=qCw6GTclRrWLx4cxemvGoQ
I won't have time today to get into this, not sure when I will, but it's a great idea extracting the icons.
Interestingly, this machine doesn't have light up icons on the front, just a single LED to indicate status (controls are only visible when the door is open) ..
Really it's only the Wash, Rinse, Dry cycle icons that we need, but it doesn't actually have icons for that.
I'll have to check the ThinQ app next time it's on, and see if it shows icons in there.
Sadly, when the app is running, it's just got "auto", no cycle icons. :(
Found this on the LG website, more marketing than anything, but I wonder if we could adapt these to make wash/rinse/dry.
@VIDGuide I'm assuming from everything said here that you do still get discrete states for the dishwasher in HA, just not in the LG app. With that in mind, I looked for any official icons, and finding none, I took a swing at some fake LG dishwasher icons.
How do you feel about these icons? I know they're just circles, but I was going for "plate, but simplified." At least it doesn't cause the same confusion that a shirt causes. I could try a fork and knife, but would have to find an icon in the LG style.
If you do like them, I'll have to figure out how to contribute to your PR, but I can add them in and you can modify your config to use them
I think those are perfect, i'd be more than happy with those! If you'd like to send me the separate images (I could splice that one up, but I don't have tools to do the transparency at the moment) I can add them to this PR, and update the sample configs and then commit that back, and we'll have one whole thing wrapped up in the PR.
It was a bit arcane, but I found out how to push my icons to your PR (see above). Go ahead and see if you can get them working in your config and if they look good in context.
Nice work! Love it. Pushed one last commit to update the YAML to use the new icons.
Sample Image:
Last thing: if you can remove the white mask from around the mini-washer (you can use a photo editing tool or a website like remove.bg) then we're good to go.
PR has been updated with the modified image :)
Added a new card, for the LG Combo Washer/Dryer. It's just a hack-job of the original 2 cards, but might save someone else the work.