search

phseiff / phseiff.github.io

The source code repo for my personal website
https://phseiff.com
Other
10 stars 2 forks source link

Dark system mode not recognized on some browsers (mobile and chrome) #2

Closed phseiff closed 4 years ago

phseiff commented 4 years ago

This might be just some browsers not supporting color scheme requests, but it might also be an issue with Dark Reader. If it is, this issue can be fixed by embedding this (https://stackoverflow.com/questions/56393880/how-do-i-detect-dark-mode-using-javascript) solution on stack overflow into the site.

phseiff commented 4 years ago

I raised this as an issue with Dark Reader, and found out it was an issue with google chrome not recognizing the systems dark mode on my specific setup (Ubuntu 18.04 with GNOME). I filed in a bug report with chromium and I am now waiting for an answer, but this issue shouldn't bother many visitors of my website since most Linux users use firefox anyway.

phseiff commented 4 years ago

Since 'no-preference' is no longer an option for 'prefers-color-scheme', I won't make the website use dark mode as the default option for browsers who do not detect the systems color scheme. Thus, this issue is closed since there is nothing more I can do about it.