search

phsmith / rundeck_exporter

Rundeck Metrics Exporter
GNU General Public License v3.0
58 stars 25 forks source link

Python 3.6 support #55

Closed arlt closed 2 years ago

arlt commented 2 years ago

with 2.4.11 we get the following error messages:

Traceback (most recent call last):
File "/opt/rundeck_exporter-2.4.11/rundeck_exporter.py", line 488, in <module>
RundeckMetricsCollector.run()
File "/opt/rundeck_exporter-2.4.11/rundeck_exporter.py", line 475, in run
REGISTRY.register(RundeckMetricsCollector())
File "/opt/rundeck_exporter-2.4.11/rundeck_exporter.py", line 157, in __init__
defaults=[1, 2, 3]
TypeError: namedtuple() got an unexpected keyword argument 'defaults'

Seems like the namedtuple change came with version 2.4.9 and needs Python 3.7.

In enterprise os like RHEL 7 (support until 2024/06), Phyton 3.6 is still supported.

Would it be possible for you to support Phyton 3.6?

phsmith commented 2 years ago

Working on it @arlt !

phsmith commented 2 years ago

Just published release v2.4.12 that should work with Python 3.6.

Please, report on any problems.

arlt commented 2 years ago

Works - perfect. Thanks!