search

phstc / gesture-translate

With Gesture Translate you can translate any text in a webpage just by zig and zag mouse movements. The translated text will be showed in the status bar
https://addons.mozilla.org/en-US/firefox/addon/239633/
Other
5 stars 3 forks source link

Service Unavailable #5

Closed piotrhoppe closed 9 years ago

piotrhoppe commented 9 years ago

Please you should update.

phstc commented 9 years ago

Hey @piotrhoppe - Unfortunately Google blocked their Translate API.

But it seems that gtranslate is accessing it in a different way that works.

Would you be able to submit a PR changing the way gesture-translate calls Google?

piotrhoppe commented 9 years ago

Ok I will try ;),

2015-05-07 13:52 GMT+02:00 Pablo Cantero notifications@github.com:

Hey @piotrhoppe https://github.com/piotrhoppe - Unfortunately Google blocked their Translate API.

But it seems that gtranslate https://github.com/bpierre/gtranslate is accessing it in a different way that works https://github.com/bpierre/gtranslate/blob/51d303b3ab199df504190012c9aa11b9855156da/providers/google-translate.js#L36-L43 .

Would you be able to submit a PR changing the way gesture-translate calls Google https://github.com/phstc/gesture-translate/blob/master/src/chrome/content/gesturegoogtrans/GoogleTranslate.js#L216-L221 ?

— Reply to this email directly or view it on GitHub https://github.com/phstc/gesture-translate/issues/5#issuecomment-99831284 .

Piotr Hoppe

piotrhoppe commented 9 years ago

I make a change and now I need access to send them.

phstc commented 9 years ago

:beers:

Super awesome! Could you send the changes via a pull request?

piotrhoppe commented 9 years ago

How I can do that? I try "git push" but I don't have access :(

remote: Permission to phstc/gesture-translate.git denied to piotrhoppe. fatal: unable to access 'https://github.com/phstc/gesture-translate.git/': The requested URL returned error: 403

phstc commented 9 years ago

We need to submit a pull request following these steps: https://help.github.com/articles/using-pull-requests/

phstc commented 9 years ago

Closed by #7.