Closed vuquangpham closed 1 year ago
Name | Link |
---|---|
Latest commit | 06db8df298b3452d7e222bd2fe93e9a53b1314a7 |
Latest deploy log | https://app.netlify.com/sites/flickity/deploys/63f4a0548853d900086ca923 |
Deploy Preview | https://deploy-preview-16--flickity.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Thanks for making PR, however, I cannot merge this PR until you update the description that answers these questions:
Thanks for making PR, however, I cannot merge this PR until you update the description that answers these questions:
- What is wrong?
- Why is that?
- How to fix it?
Sorry about that, I will explain it right here:
validateWrapAround
function, I put the wrong calculation here (comparison). The wrapAround
option will be true if only the size of Flickity viewport smaller than the total size of each cellonMatched
event, not onLoad
like the way I did before. That's my bad.onResize
event, we have forgotten to reselect the position of adjustedPosition
, it can cause a bug if the user resizes their screen. So that's all I did. If you have any questions, please let me know! Thanks.
Sorry, you still not answer what is wrong. It might be obvious to you, but not to me.
In the previous version of Flickity Responsive (2.0.3), I updated the script to enhance the wrapAround property. But during the process, I have written dummy logic, and it caused a bug (https://github.com/phucbm/flickity-responsive/issues/15). So I have removed redundant code and changed the logic of that dummy logic. So please check it again, many thanks!