search

phucbm / flickity-responsive

💻📱Responsive option for Flickity.
https://flickity.netlify.app
MIT License
7 stars 0 forks source link

Custom arrows > wrong condition cause a bug #18

Closed vuquangpham closed 1 year ago

vuquangpham commented 1 year ago

I put the wrong condition here, we have declared 3 variables and assigned the default value for them ( adjustedBeginIndex, adjustedEndIndex, selectedCellIndex). But in the condition to set the disabled attribute for each arrow, I compared the dummy condition (slidePosition === 0 || selectedCellIndex === adjustedBeginIndex), and it always runs this code.

netlify[bot] commented 1 year ago

Deploy Preview for flickity ready!

Name Link
Latest commit 3d0b29928e44edd9bdf05f50599cf42f3e078f8f
Latest deploy log https://app.netlify.com/sites/flickity/deploys/63f7295c65d6670008607e4b
Deploy Preview https://deploy-preview-18--flickity.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

phucbm commented 1 year ago

This PR will not be merged due to low code quality, lack of comments, and unclear changes.