phuccaoca123 / mb-unit

Automatically exported from code.google.com/p/mb-unit
0 stars 0 forks source link

HaltOnFailure property has no effect #41

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
setting HaltOnFailure to any value has no effect. In fact, from the 
source, I can see its value is not used anywhere. 

What's the purpose of this ? Otherwise, it should removed or at least made 
obsolete (have it display a warning when set) ?

I "reused" this property now on my installation so that 

* if false, and the failure count is not zero, then the MbUnit task still 
succeeds 

the modification to the InternalExecute() method is as follows: 

return (result.Counter.FailureCount == 0) | !HaltOnFailure ; 

In fact, this makes a lot of sense. Otherwise, by no means the number of 
failed tests or any other statistics can be gathered from the task. 
Oh, I also added output properties for the ReportCounter counters of the 
ReportResult. (vfr other issue reported MBUNIT-142) 

Original issue reported on code.google.com by astopf...@gmail.com on 31 Aug 2007 at 2:04

GoogleCodeExporter commented 9 years ago
Jeff and I decided that this property was redundant with the IgnoreFailures 
one, so
we removed it from the Gallio version of the task. IgnoreFailures is 
implemented (and
works) in both the MSBuild and the NAnt tasks (in version 3 at least). I'll 
check v2
source to see if we can remove it there too.

Original comment by julian.h...@gmail.com on 31 Aug 2007 at 3:22

GoogleCodeExporter commented 9 years ago
This has been fixed already in v2.4.2.

Original comment by jeff.br...@gmail.com on 11 Nov 2008 at 8:35