phuctinh542001 / df-frontend-2023-soranpt

https://df-frontend-2023-soranpt-assignment-1.vercel.app
0 stars 0 forks source link

Submission for assignment 1 #1

Open phuctinh542001 opened 1 year ago

phuctinh542001 commented 1 year ago

Link demo: https://df-frontend-2023-soranpt-assignment-1.vercel.app/ Link repo: https://github.com/phuctinh542001/df-frontend-2023-soranpt/tree/main/assignment-1

chinhld12 commented 1 year ago

Hi @phuctinh542001 ,

Requirements

Final result: ✅ passed 70% of requirements

Feedback:

  1. These Modals should put the button with the submit type inside the form and add onsubmit callback to handle CTA actions. Can refer here for more details. image image

  2. Get the data from localStorage should be wrapped in try/catch to catch the error when handling cases where JSON data is not valid (JSON Bad Parse Error): image

  3. The table should retain and render the filtered list after adding or removing a record of data. Currently, the table cannot resist the state and render the whole table data without filtering after making actions.

    image
phuctinh542001 commented 1 year ago

Hi @chinhld12 , thank you very much for your feedback; I really appreciate it. I'll try harder next time. 😊