search

phudak3 / ckeditor5-emoji

Emoji plugin for CKEditor 5
Other
12 stars 3 forks source link

Incompatible with ckeditor 41.x #4

Open Rockatweb opened 8 months ago

Rockatweb commented 8 months ago

Hi, your package is incompatible with the newest version of ckeditor 41.x because they renamed an export from Model to ViewModel. Have a look here: https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-41.html#exports-renamed

You need to change the following Lines in the emojicharactersnavigationview.js

Line2: import { Model, FormHeaderView, createDropdown, addListToDropdown } from '@ckeditor/ckeditor5-ui'; to Line 2: import { ViewModel, FormHeaderView, createDropdown, addListToDropdown } from '@ckeditor/ckeditor5-ui';

and

Line 75: model: new Model( { to Line 75: model: new ViewModel( {

Edit: And there is an error with the focus of the plugin

ui-dropdown-panel-focus-child-missing-focus {childView: EmojiCharactersNavigationView, dropdownPanel: DropdownPanelView} Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-ui-dropdown-panel-focus-child-missing-focus

tomitrescak commented 5 months ago

Will this be released ? Thanks!

Rockatweb commented 5 months ago

I think this repo is dead, because nothing happened since two years. But you can put this line into your package.json instead of the old one. Its working with the fork of marperia.

"@phudak/ckeditor5-emoji": "marperia/ckeditor5-emoji",

Yoann53 commented 3 months ago

I published an other package updated for ckeditor 41.4.2 : https://github.com/OTeam44/ckeditor5-emojis