kylekatarnls commented 5 years ago

Seed $cachePath passed by reference variable if requested by the user even if up_to_date_check is false

Fix https://github.com/pug-php/pug/issues/226

codecov[bot] commented 5 years ago

Codecov Report

Merging #47 into master will increase coverage by <.01%. The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #47      +/-   ##
============================================
+ Coverage     99.39%   99.39%   +<.01%     
- Complexity     2538     2540       +2     
============================================
  Files           234      234              
  Lines          6813     6818       +5     
============================================
+ Hits           6772     6777       +5     
  Misses           41       41

Impacted Files	Coverage Δ	Complexity Δ
src/Phug/Phug/Phug/Optimizer.php	`100% <100%> (ø)`	`42 <1> (+2)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2456cfa...f667a6b. Read the comment docs.

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit f667a6ba and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 99.4% (0.0% change).

View more on Code Climate.

phug-php / phug

Added path calculation in isExpired when up_to_date_check is false #47

Codecov Report