Closed bedax closed 3 years ago
by replacing line 132 with pidf.write(listener.address.encode('utf8'))
it stops erroring, but it also seems to not be replacing the notifications
Hi, thanks for the report and the praise.
I can't reproduce the issue on my system. Notably I am running python 3.9 while you seem to be running python 3.7.
What notification daemon are you using? Replacing notifications has to be supported by the notification daemon as well.
I'm using dunst 1.3.2, which has been working with replacements in the past. It does seem possible then that this is due to my python version, unfortunately I won't be able to test that any time soon, in which case this may as well be closed.
Thanks again!
In case you find a fix that works for you, feel free to create a PR and I'll test it on my system. Cheers
Somewhat bizarrely, both the problems I mentioned in this issue can be fixed by replacing the 'rb'
on line 125 with 'r'
, and the 'wb'
on line 131 with 'w'
. I'm not quite sure why that affects the replacing behaviour, but it's working for me at least
Should have thought about this earlier: https://github.com/phuhl/notify-send.py/issues/13
You just undid a fix that I added for python 3.9 for the same issue. Not sure though, how this could be done so it is compatible with both versions of python...
Yeah, that is a bit tricky then. I don't use Python much any more, but I think I have a fix. It's a bit hacky, but I'll submit a pull request anyway and you can see what you think.
When using the latest version of notify-send.py, I get the following:
Also, thank you for this project! It's very useful.