Fixed the incompatibility between Python 3.7 and 3.9

phuhl / notify-send.py

A python-script like libnotify but with improved functionality

Other

96 stars 13 forks source link

Fixed the incompatibility between Python 3.7 and 3.9 #18

Closed bedax closed 3 years ago

bedax commented 3 years ago

fixes #17

phuhl commented 3 years ago

Looks good(ish) to me, just to confirm, it does work on your system, right? :D

Just asking because of this comment, earlier:

by replacing line 132 with pidf.write(listener.address.encode('utf8')) it stops erroring, but it also seems to not be replacing the notifications

bedax commented 3 years ago

Ah yeah, on my system it seems the replacing thing wasn't working because conn = Client(address) was returning a ValueError, but that error was getting silently swallowed by the enclosing try block. This PR fixes both the problems I was experiencing, and I'm hoping it still works on yours too! :+1:

phuhl commented 3 years ago

Thanks for the fix!