search

phulshof / RetroFE

RetroFE front-end
GNU General Public License v3.0
35 stars 33 forks source link

ReflectionAlpha #3

Closed natemac closed 1 year ago

natemac commented 3 years ago

0.10.20 Menu Image Reflection Alpha 0, 0.1 or 0.9 always shows the reflection at 100% alpha (opaque). values have no effect. ` 

<item xOffset="-577" alpha="0"  width="122" layer="11" angle="0"/>`
John-Smith-UK commented 3 years ago

I second the above. Regardless of the reflectionAlpha value set, it shows as if it has been set as 1

phulshof commented 3 years ago

This is by design. Reflection is always relative to the original, because an invisible object has no reflection. As such, the alpha value for the reflection is the multiplication of the configured alpha values for the original and the reflection.

John-Smith-UK commented 3 years ago

You're missing the point, The alpha of the REFLECTION is 1 regardless if its set to less than 1. Even if I have the original items alpha set to 1, and set the reflective alpha to half of that (0.5), the reflection still outputs as 1. The behaviour has changed recently as the reflectionalpha worked as expected previously.

phulshof commented 3 years ago

I will test it, but as far as I recall I fixed that a few releases ago. Should it require additional fixes however, I'll add them to the next release.

John-Smith-UK commented 3 years ago

That must be when it was broken as it worked fine in 0.10.7

phulshof commented 3 years ago

I broke it when I added multiple reflection directions; as far as I know I fixed it afterwards, but perhaps something went wrong when I checked in the new code. Developing on both Windows and Linux sometimes causes me to make mistakes.

phulshof commented 3 years ago

I had a quick look at the code. It seems I broke it again when I added the rotation and mirror mode code. I'll make note of it, and fix it asap.

John-Smith-UK commented 3 years ago

Thanks. Visual reference if it helps:

https://imgur.com/a/hx2msWW

phulshof commented 3 years ago

I've already reproduced and fixed the bug locally. I'm currently implementing the playlist menu structure, so once that' s complete I'll check in the code, and make a new release.

phulshof commented 3 years ago

The playlist menu structure is taking a bit longer than I anticipated, so I just fixed the reflection bug in the code.