search

phungdanghoan / ksoap2-android

Automatically exported from code.google.com/p/ksoap2-android
0 stars 0 forks source link

HttpsTransportSE completely ignores Proxy #204

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Create a java.net.Proxy instance
2. Try to establish an HTTPS connection using that proxy
3. Connection fails (generally a socket timeout will occur)

I've been browsing the sources of the project and found a major code mistake 
(probably due to a merge conflict which was not resolved thoroughly).

This commit introduced the Proxy feature: 
https://github.com/mosabua/ksoap2-android/commit/7ad1c53efdbc53ce7280de74ec792ef
c9f066e4f

If you look around line 65 of HttpsServiceConnectionSE.java you'll see that 
there's an "if statement" that is completely useless (the connection instance 
if overwritten at line 74).

This causes the proxy instance to be ignored for HTTPS connections.

Original issue reported on code.google.com by cor...@gmail.com on 26 Jan 2015 at 3:42

GoogleCodeExporter commented 9 years ago 
*is overwritten

Original comment by cor...@gmail.com on 26 Jan 2015 at 3:50

GoogleCodeExporter commented 9 years ago 
Want to send a  pull request that fixes the issue?

Original comment by mosa...@gmail.com on 27 Jan 2015 at 12:53