phunware / maas-mapping-android-sdk

Phunware Mapping SDK for Android
0 stars 6 forks source link

Dt/task/swmaas 1533 fix repeating voice instructions 2 #108

Closed dtran-phunware closed 4 years ago

dtran-phunware commented 4 years ago
Context

QA reported voice instructions were repeating for the same step. This PR resolve the issue by ignoring onManueverChanged calls with the same position.

Description
Notes

It is possible and valid for multiple instructions to be TTS and displayed on the Pager within rapid succession. As long as the instruction was different form the one that preceded it.

Screen Record https://drive.google.com/file/d/1JPw9EdAo0No5qC7ie2Evk5lLhiYn0Zcq/view?usp=sharing

npike commented 4 years ago

Do we need to update the other activities to implement dispatchManeuverChanged() instead of overriding onManeuverChanged()? (like WalkTimeActivity)