phunware / maas-mapping-android-sdk

Phunware Mapping SDK for Android
0 stars 6 forks source link

SWMAAS-734 Refactor Walk and Voice scenarios to extend Routing scenario #88

Closed npike closed 4 years ago

npike commented 4 years ago

For https://jira.phunware.com/browse/SWMAAS-728 the ask from ML has been to make sure “voice” and “walking” scenarios have feature parity with iOS. Namely that they have:

The activities that represent these two scenarios share maybe 90% of their code with the activity for Routing scenario — so I have updated Routing Scenarios Activity to be a little cleaner, and these two scenarios will extend it and decorate it with their Scenario specific logic

So we end up with 3 activities:

This refactor is largely to avoid all 3 scenarios from implementing the same things three different times (map loading, walking time, route summary).

This PR has no visual changes yet (except for AudioPromp Scenario now correctly showing walking calculations). Just refactoring.

Notes

Routing Scenario

Walk Time Scenario

Voice Prompt Scenario

npike commented 4 years ago

@dtran-phunware updated PR based on feedback, and refactored the dialog used for routing POI selection to be a proper DialogFragment.