The activities that represent these two scenarios share maybe 90% of their code with the activity for Routing scenario — so I have updated Routing Scenarios Activity to be a little cleaner, and these two scenarios will extend it and decorate it with their Scenario specific logic
So we end up with 3 activities:
RoutingActivity - has all of the logic for loading a building, picking POIs, and starting a route
This refactor is largely to avoid all 3 scenarios from implementing the same things three different times (map loading, walking time, route summary).
This PR has no visual changes yet (except for AudioPromp Scenario now correctly showing walking calculations). Just refactoring.
Notes
routing.xml is now activity_routing.xml
activity_routing.xml will contain all of the shared elements across scenarios, just hidden unless a scenario turns them on
I have updated activity_routing.xml to address incorrect textsizes, lint warnings, and have converted its parent layout from a RelativeLayout to a ConstraintLayout to match best practices.
For https://jira.phunware.com/browse/SWMAAS-728 the ask from ML has been to make sure “voice” and “walking” scenarios have feature parity with iOS. Namely that they have:
The activities that represent these two scenarios share maybe 90% of their code with the activity for Routing scenario — so I have updated Routing Scenarios Activity to be a little cleaner, and these two scenarios will extend it and decorate it with their Scenario specific logic
So we end up with 3 activities:
This refactor is largely to avoid all 3 scenarios from implementing the same things three different times (map loading, walking time, route summary).
This PR has no visual changes yet (except for AudioPromp Scenario now correctly showing walking calculations). Just refactoring.
Notes