Closed dtran-phunware closed 4 years ago
Reviewing. Thanks for doing this @dtran-phunware, I think the new package structure makes it really intuitive and easy to find code for a particular goal (such as "how do I do something with Routing").
Don't forget to update the links in https://github.com/phunware/maas-mapping-android-sdk/blob/master/Samples/README.md, as it points to specific Kotlin files for certain sample Scenarios.
Can you put all of the vector drawables in drawable-anydpi
and leave just XML drawables (shapes) in drawable
? (See https://commonsware.com/blog/2015/12/21/nodpi-anydpi-wtf.html for reference)
@npike updated branch with updates to readme files as discussed.
Context
The sample app's project organization and structure was not presented in a way indicative of Phunware's coding standard. This PR provides a refactoring to match good coding practices.
NOTE: I put all of the java code in on commit just in case we wanted to easily revert.
*NO UI CHANGES