search

phuochau / react-native-thumbnail

Get thumbnail from local media. Currently, it only supports for video.
MIT License
135 stars 104 forks source link

renaming the android package name from com.reactlibrary to io.thumbnail #12

Closed prscX closed 6 years ago

prscX commented 6 years ago

Hi,

First of all, I would like to appreciate this library is really good for fetching thumbnail for a specific Video

Recently I have added react-native-link-preview library to my project, and post that I am getting exceptions while building the project

Exception: *react-native-thumbnail* & *react-native-link-preview* share the same package name

In order to solve, I have renamed the package name of both libraries. Please find below updated package name:

Post changing the package name, Everything is working as expected on both Android and iOS Platforms

Can you please merge this request and release a new build, so that we can seamlessly use this library

P.S: Doing this will make sure that in future it will not have any package name conflicts with other libraries

Please let me know in case any changes or discussion is required for the same

Thanks, Pranav

prscX commented 6 years ago

Can someone please review and merge the raised pull request. We are not able to use this library due to namespace conflicts