search

phuochau / react-native-thumbnail

Get thumbnail from local media. Currently, it only supports for video.
MIT License
135 stars 104 forks source link

Remove react-native peerDependency #19

Closed n1ru4l closed 5 years ago

n1ru4l commented 6 years ago

This is not a common practise with react-native libraries. Most specify the compatible versions in their readme.

phuochau commented 6 years ago

@n1ru4l this branch has some conflicts after I merged your other PRs

n1ru4l commented 6 years ago

@phuochau Resolved!

n1ru4l commented 6 years ago

@phuochau Could you please give an update or expected date when you will be able to review this (and my other pull requests) for this repository? I would love to have those changes in here!

n1ru4l commented 6 years ago

@phuochau Sorry for the spam, It seems like you are quire busy. Would you mind adding me as a maintainer so that we can get those pull requests merged?

phuochau commented 5 years ago

I have updated in master branch so don't need to merge this PR anymore. Thanks