Add podspec to support cocoapods projects

phuochau / react-native-thumbnail

Get thumbnail from local media. Currently, it only supports for video.

MIT License

135 stars 104 forks source link

Add podspec to support cocoapods projects #26

Closed kevinresol closed 5 years ago

n1ru4l commented 6 years ago

Duplicate of https://github.com/phuochau/react-native-thumbnail/pull/23

kevinresol commented 6 years ago

Not sure if it should be inside the ios folder. Most libraries I encountered put it in the root. And I am using my PR in my project, and it works.

n1ru4l commented 6 years ago

@kevinresol That is why I moved it from the ios folder to the project root in my pull request 👀

kevinresol commented 6 years ago

ahh I see, I didn't notice the move action 👍. Shall we merge it ?

n1ru4l commented 6 years ago

@kevinresol I actually like your PR more, since you add all the metadata to the Podfile. If you can delete the old podspec file (which is located in the ios folder) I would prefer your pull request. 😊

Sadly I have no merge/publish rights for this repository and I also tried to contact the maintainer via email without success. I have a few open pull requests that I would like to get merged. At the meantime I am maintaining my own fork 😢.