search

phuochau / react-native-thumbnail

Get thumbnail from local media. Currently, it only supports for video.
MIT License
135 stars 104 forks source link

We don't need "@Override" for android, aren't we? #7

Closed kikill95 closed 6 years ago

kikill95 commented 6 years ago

I think that we don't need "@Override" for public List<Class<? extends JavaScriptModule>> method, when I am trying run "react-native run-android" I have compile error:

/node_modules/react-native-thumbnail/android/src/main/java/com/reactlibrary/RNThumbnailPackage.java:19: error: method does not override or implement a method from a supertype
    @Override
    ^
1 error

When I remove "@Override" this works and compile fine

I am not good in Java, but I think we can do it.

Line that I think we need to remove: https://github.com/phuochau/react-native-thumbnail/blob/master/android/src/main/java/com/reactlibrary/RNThumbnailPackage.java#L19

prscX commented 6 years ago

Hi @kikill95

I have raised a PR for the same 8

I hope it will be merged ASAP. Meantime you can remove @override and use this library

Thanks Pranav

kikill95 commented 6 years ago

Hi, @prscX

Thank you

phuochau commented 6 years ago

Just updated the npm package, pls check, thanks @prscX for making PR