RN47.0 has removed `createJSModules` method

phuochau / react-native-thumbnail

Get thumbnail from local media. Currently, it only supports for video.

MIT License

135 stars 104 forks source link

RN47.0 has removed `createJSModules` method #8

Closed prscX closed 6 years ago

prscX commented 6 years ago

Hi,

RN47.0 has removed createJSModule method from ReactPackage.java. In order to make it work on Android with RN47.0, I have removed @overide annotation from RNMediaMetaPackage.java class.

Can you please merge and release so that we can seamlessly use this library on RN47.0 and above

Please let me know in case any changes are required

Thanks, Pranav

phuochau commented 6 years ago

@prscX thanks so much, I will review and merge it within today