search

phuongddx / SPWeather

SPWeather
0 stars 0 forks source link

Unit Test is dependent on actual API call. #1

Closed davidlamys closed 1 year ago

davidlamys commented 1 year ago

Hi James,

https://github.com/phuongdateh/SPWeather/blob/9a97e53a34e45902dc3aea8f7a5e9a0be3697ed7/SPWeatherTests/Modules/Home/HomeInteractorTests.swift#L33

Perhaps you'd want to consider injecting the WeatherApiServiceMock like you did in the WeatherDetailInteractorTests. Or is this intentional?

phuongddx commented 1 year ago

Hi David,

Good point for your review. When I update some testcase I missing this file. I have already update HomeInteractorTests. 👍