Assignment 1 Review

[avo1]

Hi a. Phuong, it looks like you didn't push your latest code to your repo. And I'm a little bit confused as there's a folder named 'Instagram' in your repo. Is this the lab, or the assignment? Can you help to check and update your repo?

Thanks, Dave

[phuonghuynh]

@avo1 thats last code, you can check out and run pod install to generate the workspace project on your side. I dont want to commit some configuration files that could be generated in the development side, ex: the workspace can be generated using pod install. Github repo should contains source code only.

The name Instagram is not correct bc i reused the code practiced in the lab. ^

[avo1]

Hi a, agree with you that Pods should not be committed. I notice in your git ignore, you also ignore *.xcodeproj. This xcodeproj is required to do pod init and pod install. Can you pls push that file?

By the way, this is a good template for gitignore for Swift project

[phuonghuynh]

yep, push it already

[avo1]

:+1: Nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

Grading Summary:

• Functionality: Average
• Code Style: Good
• Visual Design: Average

Overall: Average

Detailed Notes

• Great clean code. Good job utilizing the best parts from the style guide:
  • Ray Wenderlich Swift Style Guide
• I didn't show in the lecture but we should create a Movie model. In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response. For a more robust solution, you can also investigate using an ORM like Pistachio.
• • Your error message should be displayed if a network request fails and hidden again if it succeeds.
• Nice work with the custom Movie cell and encapsulating it so that it can configure itself based on the movie instance.
• Nice work loading the images asynchronously. This will avoid the UI thread being blocked (your app will not appear frozen while the images are being downloaded)
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Consider a solution that allows a user to see the entire movie overview in the Movie Detail View. Right now it is being truncated if the overview is long. Allowing scrolling by adding a UIScrollView would fix that.
• Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read Design tips for iOS9.
• If you notice when you tap on a cell to go to details page, and when you come back, that cell is selected. You may want to remove the selection by this code:

    func tableView(tableView: UITableView, didSelectRowAtIndexPath indexPath: NSIndexPath) {
        tableView.deselectRowAtIndexPath(indexPath, animated: true)
    }

• You are missing 1 requirement to implement the pull to refresh. This can be done as the instruction here

Homework is the core part of this class. Through the homework assignments you'll create real apps that you should be proud to show anybody. The more time you spend, the better your portfolio will be and the more you will learn. Try to spend a little more time next week!