Tip calculator app submission

phuongla commented 8 years ago

/cc @coderschoolreview

coderschoolreview commented 8 years ago

:laughing: Everything looks good with the format of your submission. We'll be reviewing your submission soon!

coderschoolreview commented 8 years ago

:+1: Excellent job with the Tip Calculator.

Good job with the animation and nice UI :open_mouth:
You shouldn't let the user enter invalid number, should you? I can enter bunch of leading zeros, and the dots. I can also paste some text in the text field.
When users change the default percentage in Settings, the chosen percentage in Tip is changed, it's right. But on the contrary, when users change in Tip, the chosen percentage in Settings shouldn't be changed.
Great work with using SettingManager and creating singleton.
Nice job saving the bill amount if <10 mins.
Well done with setting the currency.

Congratulation on completing the prework! The result will be emailed you next week.

phuongla commented 8 years ago

thank you :+1:

phuongla / coderschool_prework