phurwicz / hover

:speedboat: Label data at scale. Fun and precision included.
https://phurwicz.github.io/hover
MIT License
323 stars 19 forks source link

Feedback on Quickstart #27

Closed epugh closed 2 years ago

epugh commented 2 years ago

For the step "Ingredient 2 / 3: Embedding", I had to follow the instructions on space to download the model... Maybe this is a case where "if you can't figure out how to get a spacy model, you shouldn't be using hover" ;-)

python -m spacy download en_core_web_md

Also, when running in NOTEBOOK MODE with Jupyter,

This command didn't work:

show(interactive_plot, notebook_url='https://localhost:8888')

But I tried just

show(interactive_plot)

and had success, at least in showing the widgets right in the notebook....! Now, I noticed that they don't quite fit, but that might be another issue.

phurwicz commented 2 years ago

Hi Eric, many thanks! I got too absorbed into making the in-browser quickstart work that I forgot about local environments.


For the step "Ingredient 2 / 3: Embedding", I had to follow the instructions on space to download the model...

I should have put a dependency note there for folks running the code in local environment. In the Binder environment spacy and the model are installed, but they are not required by hover, thus causing the issue you found locally.

Update: f88889a62b9b90f40365564a0ceee579703db665 addresses this issue.


This command didn't work:

show(interactive_plot, notebook_url='https://localhost:8888/')

But I tried just

show(interactive_plot)

Interesting. Some used to find it the other way around. Let me put both (one of them commented out) in the code block.


Now, I noticed that they don't quite fit, but that might be another issue.

Could you share like a screenshot? I am guessing that the required plotting space is too wide and you can't scroll horizontally, making it difficult to interact with plots. Is that the case?

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 2 years ago

This issue was closed because it has been inactive for 14 days since being marked as stale.