search

phuse-org / E2E-OS-Guidance

Collaboration area for PHUSE End-to-End Open-Source Guidance
https://phuse-org.github.io/E2E-OS-Guidance/
MIT License
7 stars 3 forks source link

Feedback from Pharmaverse council #4

Closed epijim closed 1 year ago

epijim commented 2 years ago

Need to incoporate below (many thanks to Ross for driving this):

i personally found this section a bit bloated: https://phuse-org.github.io/E2E-OS-Guidance/usingos/#how-active-are-the-community-behind-a-project - the bullet points were enough in my mind

out of interest, how come riskmetric never made it into https://phuse-org.github.io/E2E-OS-Guidance/usingos/#what-can-help-me-understand-the-risks-around-using-an-open-source-project ? in your post-competitive explanation (https://phuse-org.github.io/E2E-OS-Guidance/releasingOS/ip/) i wonder if just talking of eCRF -> esub narrows this definition too much. i have a more generalised view of this that its anything where companies are needing to solve the same challenge and solving it collaboratively offers greater value than in isolation (e.g. there are similar collaborations across companies in the patient level data sharing space which we'd justify in the same way) minor bug bear - the inconsistent spelling of license (licence)

licenses - i expected a little more on copyleft and the implications of making such a choice

epijim commented 1 year ago

i personally found this section a bit bloated: https://phuse-org.github.io/E2E-OS-Guidance/usingos/#how-active-are-the-community-behind-a-project - the bullet points were enough in my mind

The context is needed based on prior discussions, specifically that activity is useful - but does not mean quality. Wording tightened up to focus on this.

https://github.com/phuse-org/E2E-OS-Guidance/pull/7/commits/57f80408c8724aa449d6777ca71f81cd10a4780b

epijim commented 1 year ago

out of interest, how come riskmetric never made it into https://phuse-org.github.io/E2E-OS-Guidance/usingos/#what-can-help-me-understand-the-risks-around-using-an-open-source-project ?

Before we mentioned the app the Validation Hub uses as a UI to riskmetric, rather than the underlying package itself. Updated to clarify there is a UI from them, as well as a more generalised tool.

This was also mentioned in #6 so needs to be elaborated.

https://github.com/phuse-org/E2E-OS-Guidance/commit/f7f68e1cd41d0e4bfb301ab3c972601ee6f8f271

epijim commented 1 year ago

in your post-competitive explanation (https://phuse-org.github.io/E2E-OS-Guidance/releasingOS/ip/) i wonder if just talking of eCRF -> esub narrows this definition too much. i have a more generalised view of this that its anything where companies are needing to solve the same challenge and solving it collaboratively offers greater value than in isolation (e.g. there are similar collaborations across companies in the patient level data sharing space which we'd justify in the same way)

Reworded to address point

https://github.com/phuse-org/E2E-OS-Guidance/commit/6f56b77c19e417b6e344a39f29a7282571765119

epijim commented 1 year ago

minor bug bear - the inconsistent spelling of license (licence)

I consequence of multiple authors :)

replaced with c (assumption as PhUSE is UK based use UK)

epijim commented 1 year ago

licenses - i expected a little more on copyleft and the implications of making such a choice

Need to circle back on this one -> suggestion to see what gaps are present in the review stage