getting package name - Githubissues

phuse-org / valtools

Validation framework for R packages used in clinical research and drug development.

https://phuse-org.github.io/valtools/

Other

51 stars 10 forks source link

getting package name #119

Closed thebioengineer closed 3 years ago

thebioengineer commented 3 years ago

Currently we have a lot of code trying to figure out the package being validated, and different techniques (dirnames, desc, etc) - would it make sense to add it into the validation.yml on creation?

Benefits:

consistent location & function to grab this info (?get_config_package())
documented intent of validation

Difficulty

Would need to be determined on creation of validation.yml - I dont think thats a huge barrier

thebioengineer commented 3 years ago

@elimillera @mariev - what do you think?

mariev commented 3 years ago

👍 absolutely! mentioned here: https://github.com/phuse-org/valtools/pull/116#discussion_r622387375

As a naiive implementation, validation_report is now assuming the "package name" is:

root <- find_root(has_file(".here") | is_rstudio_project | is_r_package | is_vcs_root)
...
pkg_name = basename(root)
...