phuse-org / valtools

Validation framework for R packages used in clinical research and drug development.
https://phuse-org.github.io/valtools/
Other
51 stars 10 forks source link

vt_use_report Name vs username #127

Closed thebioengineer closed 3 years ago

thebioengineer commented 3 years ago

vt_use_report, when figuring out who the "validation lead" is when none have been passed, uses the users name as passed into the config file b/c it uses vt_username(). The function is a misnomer that should be addressed because it returns the name of the user, not username. The lines when it is assigning validation lead should be:

val_leads_username <- username(fallback = "")
val_leads_info <- vt_get_user_info(username = val_leads_username)
val_leads_info[['role']] <- ifelse(grepl(pattern = "validation lead", 
                x = tolower(val_leads_info[['role']] )), old_role, paste0(c("Validation Lead", 
                val_leads_info[['role']] ), collapse = ", "))
vt_add_user_to_config(
    username = val_leads_username,
    name = val_leads_info[['name']] ,
    title = val_leads_info[['title']] ,
    role = val_leads_info[['role']] )

return(get_val_leads())
thebioengineer commented 3 years ago

addressed in #128